chore: Remove bundle analysis flags (#2693)

Remove bundle analysis feature flags from Gazebo. GH codecov/engineering-team#999 GH codecov/engineering-team#1214
codecov · Mar 28, 2024 · f0deb04 · f0deb04
1 parent d2a63eb
commit f0deb04
Show file tree

Hide file tree

Showing 31 changed files with 72 additions and 1,114 deletions.
diff --git a/src/pages/CommitDetailPage/CommitDetailPage.spec.tsx b/src/pages/CommitDetailPage/CommitDetailPage.spec.tsx
@@ -5,20 +5,13 @@ import { setupServer } from 'msw/node'
 import { Suspense } from 'react'
 import { MemoryRouter, Route } from 'react-router-dom'
 
-import { useFlags } from 'shared/featureFlags'
-
 import CommitPage from './CommitDetailPage'
 
 jest.mock('ui/TruncatedMessage/hooks')
 jest.mock('./Header', () => () => 'Header')
 jest.mock('./CommitCoverage', () => () => 'CommitCoverage')
 jest.mock('./CommitBundleAnalysis', () => () => 'CommitBundleAnalysis')
 
-jest.mock('shared/featureFlags')
-const mockedUseFlags = useFlags as jest.Mock<{
-  bundleAnalysisPrAndCommitPages: boolean
-}>
-
 const mockNotFoundCommit = {
   owner: {
     isCurrentUserPartOfOrg: false,
@@ -146,10 +139,6 @@ describe('CommitDetailPage', () => {
       bundleAnalysisEnabled: false,
     }
   ) {
-    mockedUseFlags.mockReturnValue({
-      bundleAnalysisPrAndCommitPages: true,
-    })
-
     server.use(
       graphql.query('CommitPageData', (req, res, ctx) => {
         if (notFoundCommit) {

diff --git a/src/pages/CommitDetailPage/CommitDetailPage.tsx b/src/pages/CommitDetailPage/CommitDetailPage.tsx
@@ -4,7 +4,6 @@ import { lazy, Suspense } from 'react'
 import { useLocation, useParams } from 'react-router-dom'
 
 import NotFound from 'pages/NotFound'
-import { useFlags } from 'shared/featureFlags'
 import Breadcrumb from 'ui/Breadcrumb'
 import Spinner from 'ui/Spinner'
 import SummaryDropdown from 'ui/SummaryDropdown'
@@ -43,10 +42,6 @@ const CommitDetailPage: React.FC = () => {
   const { provider, owner, repo, commit: commitSha } = useParams<URLParams>()
   const shortSHA = commitSha?.slice(0, 7)
 
-  const { bundleAnalysisPrAndCommitPages } = useFlags({
-    bundleAnalysisPrAndCommitPages: false,
-  })
-
   // reset cache when user navigates to the commit detail page
   const queryClient = useQueryClient()
   queryClient.setQueryData(['IgnoredUploadIds'], [])
@@ -71,8 +66,7 @@ const CommitDetailPage: React.FC = () => {
   let displayMode: TDisplayMode = DISPLAY_MODE.COVERAGE
   if (
     commitPageData?.bundleAnalysisEnabled &&
-    commitPageData?.coverageEnabled &&
-    bundleAnalysisPrAndCommitPages
+    commitPageData?.coverageEnabled
   ) {
     const queryString = qs.parse(location.search, {
       ignoreQueryPrefix: true,
@@ -86,10 +80,7 @@ const CommitDetailPage: React.FC = () => {
     }
 
     displayMode = DISPLAY_MODE.BOTH
-  } else if (
-    commitPageData?.bundleAnalysisEnabled &&
-    bundleAnalysisPrAndCommitPages
-  ) {
+  } else if (commitPageData?.bundleAnalysisEnabled) {
     displayMode = DISPLAY_MODE.BUNDLE_ANALYSIS
   }
 

diff --git a/src/pages/PullRequestPage/PullCoverage/routes/CommitsTab/CommitsTable/CommitsTable.spec.tsx b/src/pages/PullRequestPage/PullCoverage/routes/CommitsTab/CommitsTable/CommitsTable.spec.tsx
@@ -9,15 +9,8 @@ import { setupServer } from 'msw/node'
 import { mockIsIntersecting } from 'react-intersection-observer/test-utils'
 import { MemoryRouter, Route } from 'react-router-dom'
 
-import { useFlags } from 'shared/featureFlags'
-
 import CommitsTable from './CommitsTable'
 
-jest.mock('shared/featureFlags')
-const mockedUseFlags = useFlags as jest.Mock<{
-  bundleAnalysisPrAndCommitPages: boolean
-}>
-
 const mockRepoOverview = (bundleAnalysisEnabled = false) => ({
   owner: {
     repository: {
@@ -152,10 +145,6 @@ describe('CommitsTable', () => {
   }: SetupArgs) {
     const queryClient = new QueryClient()
 
-    mockedUseFlags.mockReturnValue({
-      bundleAnalysisPrAndCommitPages: true,
-    })
-
     server.use(
       graphql.query('GetRepoOverview', (req, res, ctx) => {
         return res(

diff --git a/src/pages/PullRequestPage/PullCoverage/routes/CommitsTab/CommitsTable/CommitsTable.tsx b/src/pages/PullRequestPage/PullCoverage/routes/CommitsTab/CommitsTable/CommitsTable.tsx
@@ -12,7 +12,6 @@ import { useParams } from 'react-router-dom'
 
 import { useCommits } from 'services/commits/useCommits'
 import { useRepoOverview } from 'services/repo'
-import { useFlags } from 'shared/featureFlags'
 import Spinner from 'ui/Spinner'
 
 import { createCommitsTableData } from './createCommitsTableData'
@@ -89,9 +88,6 @@ const CommitsTable = () => {
   const { ref, inView } = useInView()
   const { provider, owner, repo, pullId } = useParams<URLParams>()
   const { data: overview } = useRepoOverview({ provider, owner, repo })
-  const { bundleAnalysisPrAndCommitPages } = useFlags({
-    bundleAnalysisPrAndCommitPages: false,
-  })
 
   const {
     data: commitsData,
@@ -122,8 +118,7 @@ const CommitsTable = () => {
   const columns = useMemo(() => {
     if (
       overview?.bundleAnalysisEnabled &&
-      !baseColumns.some((column) => column.id === 'bundleAnalysis') &&
-      bundleAnalysisPrAndCommitPages
+      !baseColumns.some((column) => column.id === 'bundleAnalysis')
     ) {
       return [
         ...baseColumns,
@@ -136,7 +131,7 @@ const CommitsTable = () => {
     }
 
     return baseColumns
-  }, [bundleAnalysisPrAndCommitPages, overview?.bundleAnalysisEnabled])
+  }, [overview?.bundleAnalysisEnabled])
 
   const table = useReactTable({
     columns,

diff --git a/...PullRequestPage/PullCoverage/routes/CommitsTab/CommitsTableTeam/CommitsTableTeam.spec.tsx b/...PullRequestPage/PullCoverage/routes/CommitsTab/CommitsTableTeam/CommitsTableTeam.spec.tsx
@@ -9,15 +9,8 @@ import { setupServer } from 'msw/node'
 import { mockIsIntersecting } from 'react-intersection-observer/test-utils'
 import { MemoryRouter, Route } from 'react-router-dom'
 
-import { useFlags } from 'shared/featureFlags'
-
 import CommitsTableTeam from './CommitsTableTeam'
 
-jest.mock('shared/featureFlags')
-const mockedUseFlags = useFlags as jest.Mock<{
-  bundleAnalysisPrAndCommitPages: boolean
-}>
-
 const mockRepoOverview = (bundleAnalysisEnabled = false) => ({
   owner: {
     repository: {
@@ -128,10 +121,6 @@ describe('CommitsTableTeam', () => {
   }: SetupArgs) {
     const queryClient = new QueryClient()
 
-    mockedUseFlags.mockReturnValue({
-      bundleAnalysisPrAndCommitPages: true,
-    })
-
     server.use(
       graphql.query('GetRepoOverview', (req, res, ctx) => {
         return res(

diff --git a/...ages/PullRequestPage/PullCoverage/routes/CommitsTab/CommitsTableTeam/CommitsTableTeam.tsx b/...ages/PullRequestPage/PullCoverage/routes/CommitsTab/CommitsTableTeam/CommitsTableTeam.tsx
@@ -12,7 +12,6 @@ import { useParams } from 'react-router-dom'
 
 import { useCommitsTeam } from 'services/commits'
 import { useRepoOverview } from 'services/repo'
-import { useFlags } from 'shared/featureFlags'
 import Spinner from 'ui/Spinner'
 import 'ui/Table/Table.css'
 
@@ -77,9 +76,6 @@ export default function CommitsTableTeam() {
   const { provider, owner, repo, pullId } = useParams<URLParams>()
   const { ref, inView } = useInView()
   const { data: overview } = useRepoOverview({ provider, owner, repo })
-  const { bundleAnalysisPrAndCommitPages } = useFlags({
-    bundleAnalysisPrAndCommitPages: false,
-  })
 
   const {
     data: commitsData,
@@ -110,8 +106,7 @@ export default function CommitsTableTeam() {
   const columns = useMemo(() => {
     if (
       overview?.bundleAnalysisEnabled &&
-      !baseColumns.some((column) => column.id === 'bundleAnalysis') &&
-      bundleAnalysisPrAndCommitPages
+      !baseColumns.some((column) => column.id === 'bundleAnalysis')
     ) {
       return [
         ...baseColumns,
@@ -124,7 +119,7 @@ export default function CommitsTableTeam() {
     }
 
     return baseColumns
-  }, [bundleAnalysisPrAndCommitPages, overview?.bundleAnalysisEnabled])
+  }, [overview?.bundleAnalysisEnabled])
 
   const table = useReactTable({
     columns,

diff --git a/src/pages/PullRequestPage/PullRequestPage.spec.tsx b/src/pages/PullRequestPage/PullRequestPage.spec.tsx
@@ -13,7 +13,6 @@ import PullRequestPage from './PullRequestPage'
 jest.mock('shared/featureFlags')
 const mockedUseFlags = useFlags as jest.Mock<{
   multipleTiers: boolean
-  bundleAnalysisPrAndCommitPages: boolean
 }>
 
 jest.mock('./Header', () => () => 'Header')
@@ -189,7 +188,6 @@ describe('PullRequestPage', () => {
   }: SetupArgs) {
     mockedUseFlags.mockReturnValue({
       multipleTiers: true,
-      bundleAnalysisPrAndCommitPages: true,
     })
 
     server.use(

diff --git a/src/pages/PullRequestPage/PullRequestPage.tsx b/src/pages/PullRequestPage/PullRequestPage.tsx
@@ -42,9 +42,8 @@ const Loader = () => (
 function PullRequestPage() {
   const location = useLocation()
   const { provider, owner, repo, pullId } = useParams<URLParams>()
-  const { multipleTiers, bundleAnalysisPrAndCommitPages } = useFlags({
+  const { multipleTiers } = useFlags({
     multipleTiers: false,
-    bundleAnalysisPrAndCommitPages: false,
   })
 
   const { data: overview } = useRepoOverview({ provider, owner, repo })
@@ -68,11 +67,7 @@ function PullRequestPage() {
   let defaultDropdown: Array<'coverage' | 'bundle'> = []
   // default to displaying only coverage
   let displayMode: TDisplayMode = DISPLAY_MODE.COVERAGE
-  if (
-    data?.bundleAnalysisEnabled &&
-    data?.coverageEnabled &&
-    bundleAnalysisPrAndCommitPages
-  ) {
+  if (data?.bundleAnalysisEnabled && data?.coverageEnabled) {
     const queryString = qs.parse(location.search, {
       ignoreQueryPrefix: true,
       depth: 1,
@@ -85,7 +80,7 @@ function PullRequestPage() {
     }
 
     displayMode = DISPLAY_MODE.BOTH
-  } else if (data?.bundleAnalysisEnabled && bundleAnalysisPrAndCommitPages) {
+  } else if (data?.bundleAnalysisEnabled) {
     displayMode = DISPLAY_MODE.BUNDLE_ANALYSIS
   }