Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Pull.flare to GCS #70

Closed
Tracked by #100
katia-sentry opened this issue Jun 20, 2023 · 3 comments
Closed
Tracked by #100

Migrate Pull.flare to GCS #70

katia-sentry opened this issue Jun 20, 2023 · 3 comments
Assignees
Labels

Comments

@katia-sentry
Copy link
Contributor

No description provided.

@katia-sentry
Copy link
Contributor Author

blocked by #31

@katia-sentry katia-sentry added this to the Codecov's Report Data will be stored in GCS milestone Jun 20, 2023
@giovanni-guidini
Copy link

TO make it easier to migrate future columns we are implementing a descriptor that does the heavy lifting. See https://github.com/codecov/codecov-api/pull/1609

@trent-codecov trent-codecov removed this from the Codecov's Report Data will be stored in GCS milestone Jul 17, 2023
@giovanni-guidini
Copy link

UPDATE we are going to do this one after Commit.report

giovanni-guidini added a commit to codecov/codecov-api that referenced this issue Aug 3, 2023
This commit is the initial work (+ migration) to move `Pull.flare` to storage.
This column has crashed the DB in only 1 occasion in the past.

Notice that Pull doesn't have `commit` (because multiple commits refer to the same pull)
the issue with that is that in `Pull.get_commitid` I set it to return `"multiple_commits"`.
This should not affect the usage of `ArchiveField`, but will make it so that the data is
written to `/v4/repos/REPO_HASH/commits/multiple_commits/json_data/...`

It's fine by me, but we might want to consider another solution.

Part of codecov/engineering-team#70
giovanni-guidini added a commit to codecov/codecov-api that referenced this issue Aug 7, 2023
This commit is the initial work (+ migration) to move `Pull.flare` to storage.
This column has crashed the DB in only 1 occasion in the past.

Notice that Pull doesn't have `commit` (because multiple commits refer to the same pull).
To deal with that I changed the writing of data to have 2 paths: one with commit, and one
without the commit. So pulls data will be written in the repo level (in storage).

Part of codecov/engineering-team#70
giovanni-guidini added a commit to codecov/worker that referenced this issue Aug 10, 2023
This commit is the initial work to move `Pull.flare` to storage.
This column has crashed the DB in only 1 occasion in the past.

Notice that Pull doesn't have `commit` (because multiple commits refer to the same pull).
To deal with that I changed the writing of data to have 2 paths: one with commit, and one
without the commit. So pulls data will be written in the repo level (in storage).

codecov/engineering-team#70
giovanni-guidini added a commit to codecov/codecov-api that referenced this issue Aug 11, 2023
This commit is the initial work (+ migration) to move `Pull.flare` to storage.
This column has crashed the DB in only 1 occasion in the past.

Notice that Pull doesn't have `commit` (because multiple commits refer to the same pull).
To deal with that I changed the writing of data to have 2 paths: one with commit, and one
without the commit. So pulls data will be written in the repo level (in storage).

Part of codecov/engineering-team#70
giovanni-guidini added a commit to codecov/codecov-api that referenced this issue Aug 15, 2023
This commit is the initial work (+ migration) to move `Pull.flare` to storage.
This column has crashed the DB in only 1 occasion in the past.

Notice that Pull doesn't have `commit` (because multiple commits refer to the same pull).
To deal with that I changed the writing of data to have 2 paths: one with commit, and one
without the commit. So pulls data will be written in the repo level (in storage).

Part of codecov/engineering-team#70
giovanni-guidini added a commit to codecov/codecov-api that referenced this issue Aug 15, 2023
This commit is the initial work (+ migration) to move `Pull.flare` to storage.
This column has crashed the DB in only 1 occasion in the past.

Notice that Pull doesn't have `commit` (because multiple commits refer to the same pull).
To deal with that I changed the writing of data to have 2 paths: one with commit, and one
without the commit. So pulls data will be written in the repo level (in storage).

Part of codecov/engineering-team#70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants