-
Notifications
You must be signed in to change notification settings - Fork 139
Version 2.1.3 fails to find gcov files #261
Comments
I do notice that it uses three dots |
@nmoinvaz That's actually part of the "slight modifications" 😅, anywhere you see the three dots, replace it with (I also noticed that my original link was not a "permalink" and changed when I pushed a new fix to the PR, I've now updated it to be a permalink). |
I think this might be fixed with the latest master branch since it no longer uses |
@nmoinvaz No, I'm pretty sure that's the commit that broke |
I see the version numbers on Pypi are different than in git. |
If that broke it, I'm going to to need to rollback, unless you can somehow test this @nmoinvaz ? |
Ok I will take a look at it |
See #256 |
I was able to reproduce. I have two commits that should help. Please give them a shot. |
Signed-off-by: oleg.hoefling <[email protected]>
This should be resolved now. |
Fixed via #263 and released in |
Recently codecov stopped uploading my C code coverage on a Python C extension I have written.
In this job,
tox
is usingcodecov==2.1.1
, and the upload succeeds.In this job,
tox
is usingcodecov==2.1.3
and I see the following error:(I've modified this slightly to make it a bit easier to read by shortening some paths and breaking up one extra long line).
Unfortunately I don't have time to create a minimal reproducer, but if you clone the zoneinfo repository and run
tox -e gcov
, that should generate the coverage files, and I'm usingscripts/upload_codecov.py
to upload the coverage files — it is just a script that finds the XML file output thatgcovr
emits, and passes that tocodecov -f
.I'm guessing #167 is the culprit.
The text was updated successfully, but these errors were encountered: