Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Commit

Permalink
Remove 'x-amz-acl': 'public-read' header (#178)
Browse files Browse the repository at this point in the history
Codecov recently did some fundamental storage changes on its backend in an effort to greatly improve the reliability of our underlying storage systems. As a result the `X-Amz-Acl: public-read` header is no longer needed, and may result in 400 errors if used. 

You can see a similar fix in codecov-python that removes that header here: https://github.com/codecov/codecov-python/pull/253/files
  • Loading branch information
eliatcodecov authored May 18, 2020
1 parent eeff4e1 commit 0d7b9b0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/codecov.js
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ var sendToCodecovV3 = function(
body: upload_body,
headers: {
'Content-Type': 'text/plain',
'x-amz-acl': 'public-read',
},
},
function(err) {
Expand Down

0 comments on commit 0d7b9b0

Please sign in to comment.