Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove settings and invoices internal endpoints #654

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Jul 3, 2024

Now that these endpoints have been migrated to GQL, remove unused internal endpoint code.

https://codecov.sentry.io/performance/summary/?environment=production&project=5215654&query=&referrer=performance-transaction-summary&statsPeriod=14d&transaction=%2Finternal%2F%7Bservice%7D%2F%7Bowner_username%7D%2Finvoices%2F&unselectedSeries=p100%28%29&unselectedSeries=avg%28%29

This closes codecov/engineering-team#1502

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (1f9dcf3) to head (9273eb2).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   91.54%   91.52%   -0.02%     
==========================================
  Files         621      621              
  Lines       16569    16531      -38     
==========================================
- Hits        15168    15130      -38     
  Misses       1401     1401              
Flag Coverage Δ
unit 91.52% <100.00%> (-0.02%) ⬇️
unit-latest-uploader 91.52% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/enterprise_urls.py 100.00% <100.00%> (ø)
api/internal/owner/views.py 98.96% <ø> (-0.12%) ⬇️
api/internal/self_hosted/serializers.py 100.00% <ø> (ø)
api/internal/self_hosted/views.py 100.00% <100.00%> (ø)
api/internal/urls.py 97.22% <ø> (-0.08%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov-public-qa bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (1f9dcf3) to head (9273eb2).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   91.54%   91.52%   -0.02%     
==========================================
  Files         621      621              
  Lines       16569    16531      -38     
==========================================
- Hits        15168    15130      -38     
  Misses       1401     1401              
Flag Coverage Δ
unit 91.52% <100.00%> (-0.02%) ⬇️
unit-latest-uploader 91.52% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/enterprise_urls.py 100.00% <100.00%> (ø)
api/internal/owner/views.py 98.96% <ø> (-0.12%) ⬇️
api/internal/self_hosted/serializers.py 100.00% <ø> (ø)
api/internal/self_hosted/views.py 100.00% <100.00%> (ø)
api/internal/urls.py 97.22% <ø> (-0.08%) ⬇️

Impacted file tree graph

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (1f9dcf3) to head (9273eb2).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #654        +/-   ##
================================================
- Coverage   95.94000   95.93000   -0.01000     
================================================
  Files           799        799                
  Lines         17886      17848        -38     
================================================
- Hits          17160      17122        -38     
  Misses          726        726                
Flag Coverage Δ
unit 91.52% <100.00%> (-0.02%) ⬇️
unit-latest-uploader 91.52% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review July 3, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Remove /settings and /invoice rest API endpoints
1 participant