dev: add Ruff PERF rules, fix E711 and F841 #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #624 +/- ##
=======================================
Coverage 91.51% 91.52%
=======================================
Files 620 620
Lines 16478 16469 -9
=======================================
- Hits 15080 15073 -7
+ Misses 1398 1396 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
================================================
+ Coverage 95.93000 95.94000 +0.01000
================================================
Files 798 798
Lines 17795 17786 -9
================================================
- Hits 17072 17065 -7
+ Misses 723 721 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #624 +/- ##
=======================================
Coverage 91.51% 91.52%
=======================================
Files 620 620
Lines 16478 16469 -9
=======================================
- Hits 15080 15073 -7
+ Misses 1398 1396 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ajay-sentry
commented
Jun 19, 2024
| @@ -262,9 +262,7 @@ def get_and_modify_owner(self, user_dict, request) -> Owner: | |||
| ] | |||
|
|
|||
| self._check_enterprise_organizations_membership(user_dict, formatted_orgs) | |||
| upserted_orgs = [] | |||
ajay-sentry
commented
Jun 19, 2024
| if coverage_status: | ||
| to_be_included = [] |
ajay-sentry
commented
Jun 19, 2024
| @@ -56,7 +56,7 @@ def _flatten_selections(self, selection_set: SelectionSetNode) -> Iterable[Node] | |||
| if isinstance(selection, FragmentSpreadNode): | |||
| fragment = self.info.fragments[selection.name.value] | |||
| for selection in fragment.selection_set.selections: | |||
| selections.append(selection) | |||
ajay-sentry
commented
Jun 19, 2024
| @@ -419,16 +419,16 @@ def compute_report( | |||
| branch=self.branch, | |||
| ) | |||
|
|
|||
| results = [] | |||
| for measurable_id in measurable_ids: | |||
ajay-sentry
commented
Jun 19, 2024
| @@ -29,7 +29,7 @@ def file_reports(self): | |||
| def flags(self): | |||
| """returns dict(:name=<Flag>)""" | |||
| flags_dict = {} | |||
| for sid, session in self.sessions.items(): | |||
JerrySentry
approved these changes
Jun 20, 2024
nora-codecov
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
Part of the lint enhancement epic, this PR aims to add the Perflint PERF rules, and fix E711 and F841, which are for Comparison to None should be cond is None and Local variable {name} is assigned to but never used respectively.
These can be found here:
Links to relevant tickets
Closes codecov/engineering-team#1965
What does this PR do?
This PR adds the rules listed above and fixes any errors that stemmed from them.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.