Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add manual trigger option when clicking sync repos #401

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

JerrySentry
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?

Use the manual_trigger option when clicking the sync repos button in the UI, this will get propagated to sync languages task to reach out to GH for languages.

Links to relevant tickets

codecov/engineering-team#961

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@JerrySentry JerrySentry marked this pull request as ready for review February 15, 2024 18:58
@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0f67d9) 96.07% compared to head (f6a6690) 96.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         636      636           
  Lines       16581    16581           
=======================================
  Hits        15931    15931           
  Misses        650      650           
Flag Coverage Δ
unit 96.07% <ø> (ø)
unit-latest-uploader 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0f67d9) 96.07% compared to head (f6a6690) 96.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         636      636           
  Lines       16581    16581           
=======================================
  Hits        15931    15931           
  Misses        650      650           
Flag Coverage Δ
unit 96.07% <ø> (ø)
unit-latest-uploader 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ov_auth/commands/owner/interactors/trigger_sync.py 100.00% <ø> (ø)
services/refresh.py 100.00% <ø> (ø)
services/task/task.py 80.90% <ø> (ø)

Impacted file tree graph

@JerrySentry JerrySentry merged commit 5286410 into main Feb 15, 2024
20 checks passed
@JerrySentry JerrySentry deleted the api_961 branch February 15, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants