feat: trigger label analysis task after update #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From codecov/worker#21 we have a different way of handling updates for `LabelAnalysisRequest` objects. This is important because we want to use these objects to extract metrics from ATS. However to actually have the updated values we need to trigger the task again. These changes trigger the task again :3 closes codecov/engineering-team#456
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
Codecov Report
@@ Coverage Diff @@
## main #131 +/- ##
=====================================
Coverage 95.35 95.35
=====================================
Files 702 702
Lines 14958 14965 +7
=====================================
+ Hits 14262 14269 +7
Misses 696 696
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scott-codecov
approved these changes
Sep 14, 2023
giovanni-guidini
deleted the
gio/trigger-label-analysis-task-after-update
branch
scott-codecov
added a commit
that referenced
this pull request
Sep 14, 2023
* main: (74 commits) Fix indentation error (#133) Add cache cleanup (#130) Feature/lint pre commit (#134) feat: trigger label analysis task after update (#131) Filter file comparisons by flags (#129) chore: Remove hard-coded dev BB redirect URL (#132) feat: Validate OIDC ID token during Sentry OAuth flow (#52) Adding beginnings of GHA CI (#127) feat: Filter flags by flags for pathContents (#128) Create checkbox in Owner form in Django admin to set uses_invoice (#109) build(deps): bump certifi from 2020.6.20 to 2023.7.22 (#32) Feature/no compile (#126) Bump django from 4.2.2 to 4.2.3 (#42) Don't compile since source is available (#106) feat: Add firstPull resolver to GraphQL pull type (#108) chore: Upgrade requests and redis dependencies (#124) Update LICENSE (#122) Attempt migration (#121) 359 adjust monthly uploads for trialled customers (#119) Add changes for monthly uploads to account for trialing customer (#101) ...
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From codecov/worker#21 we have a different way of handling updates for
LabelAnalysisRequestobjects.This is important because we want to use these objects to extract metrics from ATS.
However to actually have the updated values we need to trigger the task again.
These changes trigger the task again :3
closes codecov/engineering-team#456
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.