Set bot on owner even if bot name hasn't changed

[michelletran-sentry]

Purpose/Motivation

The current problem is that customers are not having their bots picked up properly. This is because the bots are not being populated during the YAML save workflow onto the owners.bot field. This will hopefully attempt to save the bot if the user creates the bot after the YAML is updated (as it wasn't updating before).

Links to relevant tickets

This fixes: https://github.com/codecov/internal-issues/issues/1244

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

[codecov-notifications]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (5df99ba) to head (ae93fda).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1193   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         493      493           
  Lines       16851    16851           
=======================================
  Hits        16157    16157           
  Misses        694      694           

Flag	Coverage Δ
unit	95.88% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[spalmurray-codecov]

nice job tracking this one down!

[overwatch-beta]

🚨 Sentry detected 4 potential issues in your recent changes 🚨

• 99% chance FATAL at Line 76, codecov_auth/commands/owner/interactors/set_yaml_on_owner.py: Incorrect type for owner username leads to incorrect bot assignment.
• 95% chance FATAL at Line 76, codecov_auth/commands/owner/interactors/set_yaml_on_owner.py: Incorrect type assignment to owner's ID field.
• 95% chance FATAL at Line 76, codecov_auth/commands/owner/interactors/set_yaml_on_owner.py: Incorrect type passed to bot assignment causes the issue.
• 95% chance FATAL at Line 76, codecov_auth/commands/owner/interactors/set_yaml_on_owner.py: Incorrect type of owner username leads to invalid bot ID.

[seer-by-sentry]

🚨 Sentry detected 1 potential issue in your recent changes 🚨

• Line 76, codecov_auth/commands/owner/interactors/set_yaml_on_owner.py: Argument "owner_username" to "get_ownerid_if_member" has incompatible type "dict[Any, Any] | Any | None"; expected "str"

  • ownerid receives string instead of integer due to incorrect owner_username.
  • This may cause issues similar to: #6418968899

_{Did you find this useful? React with a 👍 or 👎}