Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: override commit and pr values for PR cases #1657

Merged
merged 9 commits into from
Nov 15, 2024
Merged

fix: override commit and pr values for PR cases #1657

merged 9 commits into from
Nov 15, 2024

Conversation

thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Nov 15, 2024 •
edited
Loading

@thomasrockhu-codecov thomasrockhu-codecov merged commit 5c47607 into main Nov 15, 2024
13 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/fix-pr-and-commit-fixes branch November 15, 2024 15:27
@vtjnash
Copy link

vtjnash commented Nov 18, 2024

If I understand this PR correctly, it is now causing "Fork detected, tokenless uploading used" to be printed (harmlessly?) on many uploads, when following the documentation to pass the value as CODECOV_TOKEN, since this renamed it to CC_TOKEN. For example: https://github.com/vtjnash/Glob.jl/actions/runs/11898703761/job/33155756934

@thomasrockhu-codecov
Copy link
Contributor Author

@vtjnash 5.0.3 should fix the issue, but if it does not, please open one in this repo and tag @codecov/report-upload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drazisil-codecov drazisil-codecov drazisil-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasrockhu-codecov @vtjnash @drazisil-codecov