-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make requirement that coverage *must* be in XML more obvious #456
Comments
This comment has been minimized.
This comment has been minimized.
I was specifying |
This comment has been minimized.
This comment has been minimized.
Oh, I misunderstood you, yes this file isn't processed correctly, you are right.
…------------------ Original ------------------
From: ***@***.***>;
Date: 2021年8月14日(星期六) 晚上9:56
To: ***@***.***>;
Cc: ***@***.***>; ***@***.***>;
Subject: Re: [codecov/codecov-action] Make requirement that coverage *must* be in XML more obvious (#456)
I was specifying files: .coverage and it was being uploaded, but it was considered corrupt (I don't remember the exact error message at this point).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
The Python example suggests that
But this doesn't seem to actually be the case. Could the documentation be updated to clarify what actually needs to happen? |
refs codecov/codecov-action#456 - turns out the coverage files need to be in XML for them to work with codecov, so this commit adds cobertura (XML) as a reporter
refs codecov/codecov-action#456 - turns out the coverage files need to be in XML for them to work with codecov, so this commit adds cobertura (XML) as a reporter
Ah, good to know... |
It works fine with JSON for me: [2021-11-02T07:58:05.090Z] ['info'] => Found 1 possible coverage files:
./coverage/coverage.json
[2021-11-02T07:58:05.090Z] ['verbose'] End of network processing
[2021-11-02T07:58:05.090Z] ['info'] Processing ./coverage/coverage.json...
[2021-11-02T07:58:05.094Z] ['info'] Using manual override from args. |
The uploader now runs |
Spent a good hour on this until I realized that maybe everyone was running
coverage xml
for a reason. It is only implied and never out-right mentioned in the README.The text was updated successfully, but these errors were encountered: