Files are ignored and extra files are picked #1354
Comments
|
@HarelM , Can you see if passing |
|
Thanks! Looks like |
I don't disagree! I think the challenge was, by the time we realized that it didn't enough customers were using the action that just turning it off would have broken a lot of coverage for folks, since coverage files that had been found would suddenly stop being uploaded. We don't always do the best job at it, but we try really hard not to fundamentally change your coverage on your without warning. Glad that worked as I hoped. (@rohan-at-sentry Please see customer feedback above <3 |
|
Well, in my case it did change the coverage from something I expected to something else, but yes, backwards compatibility isn't easy... |
## Issue For about a week, we did not get any coverage reports added to PRs. Reason was a failing upload, due to the codecov rate limit. `[2024-05-24T09:08:19.271Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2453s.', code='throttled')}` ## Solution - Update from `codecov-action@v3` to `codecov-action@v4`. To keep the same coverage, we need to add the flag `disable_search: true`. Otherwise, around 1500 coverage files would be uploaded and increase our coverage from 50% to 85%. This solution was suggested in: - codecov/codecov-action#1354 Maybe we need to add the token as `token: ${{ secrets.CODECOV_TOKEN }}`, when we run into the rate-limit again. But it might not necessary, since they enabled token-free uploads for forks of open-source repositories. ## Coverage Change -1.63% The change seems to be due to 2 reasons: - The old HEAD lies 14 commits in the past - Ending `}` are not counted as "covered" and just ignored. Therefore the relative amount of uncovered parts is increased.
## Issue For about a week, we did not get any coverage reports added to PRs. Reason was a failing upload, due to the codecov rate limit. `[2024-05-24T09:08:19.271Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2453s.', code='throttled')}` ## Solution - Update from `codecov-action@v3` to `codecov-action@v4`. To keep the same coverage, we need to add the flag `disable_search: true`. Otherwise, around 1500 coverage files would be uploaded and increase our coverage from 50% to 85%. This solution was suggested in: - codecov/codecov-action#1354 Maybe we need to add the token as `token: ${{ secrets.CODECOV_TOKEN }}`, when we run into the rate-limit again. But it might not necessary, since they enabled token-free uploads for forks of open-source repositories. ## Coverage Change -1.63% The change seems to be due to 2 reasons: - The old HEAD lies 14 commits in the past - Ending `}` are not counted as "covered" and just ignored. Therefore the relative amount of uncovered parts is increased.
## Issue For about a week, we did not get any coverage reports added to PRs. Reason was a failing upload, due to the codecov rate limit. `[2024-05-24T09:08:19.271Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2453s.', code='throttled')}` ## Solution - Update from `codecov-action@v3` to `codecov-action@v4`. To keep the same coverage, we need to add the flag `disable_search: true`. Otherwise, around 1500 coverage files would be uploaded and increase our coverage from 50% to 85%. This solution was suggested in: - codecov/codecov-action#1354 Maybe we need to add the token as `token: ${{ secrets.CODECOV_TOKEN }}`, when we run into the rate-limit again. But it might not necessary, since they enabled token-free uploads for forks of open-source repositories. ## Coverage Change -1.63% The change seems to be due to 2 reasons: - The old HEAD lies 14 commits in the past - Ending `}` are not counted as "covered" and just ignored. Therefore the relative amount of uncovered parts is increased.
|
I agree that the search should be disabled when using the I also don't understand the reasoning for not making this change, since, as far as I know, when using file(s), it won't actually upload other files that are found by the search, it just outputs the search result (list of files found). |
|
@aj-codecov We may want to take another look at this behavior. Here's another example of feedback: |
I have the following run:
https://github.com/IsraelHikingMap/Site/actions/runs/8556672091/job/23447062211
Which I configured to upload two files:
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov do-upload -f ./Tests/IsraelHiking.API.Tests/coverage.info -f ./IsraelHiking.Web/coverage/lcov.info --git-service githubBut the codecov action upload another file I didn't specify:
Here's a screenshot of the log:
This is using v4 of codecov action.
The text was updated successfully, but these errors were encountered: