Improve memory usage when extracting zip archives #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
May 26, 2023
This is obtained through the upgrade of the 'extract' library. Upstream patch: codeclysm/extract#21
6 tasks
cmaglie
added a commit
to arduino/arduino-cli
that referenced
this pull request
May 26, 2023
This is obtained through the upgrade of the 'extract' library. Upstream patch: codeclysm/extract#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .zip extractor requires an
io.ReaderAtand the size of the archive:io.Readerto see if it implements the interfaceio.ReaderAtSeekmethod, usually if the reader is aReaderAtit's very liketly to implement alsoio.SeekerIf the two conditions above are satisfied we can avoid buffering the entire archive in memory.
This PR also remove the dependency on the deprecated
io/utilpackage.