Support alphanumeric ruby gem versions #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Can you squash the commits before you merge? |
| @@ -40,6 +40,9 @@ def calculate_points(upgrade_version) | |||
|
|
|||
| def current_version | |||
| @current_version ||= Versionomy.parse(gem_version.to_s) | |||
| rescue Versionomy::Errors::ParseError | |||
| version = Versionomy.parse(gem_version.to_s, :rubygems) | |||
| Versionomy.create(major: version.field0, minor: version.field1, tiny: version.field2) | |||
There was a problem hiding this comment.
Should this be memoized, too?
There was a problem hiding this comment.
Ahh, yes it should. 👍
dblandin
force-pushed
the
devon/support-alphanumeric-gem-versions
branch
from
1052a09 to
e0bd413
Compare
Supports alphanumeric gem versions like `3.0.0.rc.2` or `2.2.2.backport2`
dblandin
force-pushed
the
devon/support-alphanumeric-gem-versions
branch
from
e0bd413 to
316f909
Compare
|
@jp @gordondiggs Squashed and rebased. |
|
👍 |
dblandin
added a commit
that referenced
this pull request
Feb 15, 2016
…m-versions Support alphanumeric ruby gem versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple issues.
@codeclimate/review 🔎