Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to devtools #4563

Open
wants to merge 16 commits into
base: 3.x
Choose a base branch
from

Conversation

thomashohn
Copy link
Contributor

@thomashohn thomashohn commented Nov 12, 2024

Motivation/Description of the PR

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@thomashohn
Copy link
Contributor Author

thomashohn commented Nov 12, 2024

@kobenguyent - maybe you have an idea of the failing tests?
The idea was to have the tests running and then switch driver version

@kobenguyent
Copy link
Collaborator

@kobenguyent - maybe you have an idea of the failing tests? The idea was to have the tests running and then switch driver version

hi @thomashohn I reckoned you removed the devtools protocol but still calling this https://github.com/codeceptjs/CodeceptJS/pull/4563/files#diff-06a1e9f6d0b95cc16170ad023c4131c7d35c145e9c6375e492ab48a8b2fa10e4R646

I'd think that causes the issue. Also please check the impact of this removal as this may cause many issues related to this change.

@thomashohn
Copy link
Contributor Author

I guess I was uncertain what should happen to methods using
startRecordingTraffic and stopRecordingTraffic which use this.page

@kobenguyent
Copy link
Collaborator

kobenguyent commented Nov 12, 2024

I guess I was uncertain what should happen to methods using

startRecordingTraffic and stopRecordingTraffic which use this.page

If I'm not wrong, Those methods use the devtools protocol as well.

Initially, you could refer to this PR which introduces devtools #4105

@thomashohn thomashohn changed the title [WIP] Attempt to update webdriverio Remove dependency to devtools Nov 12, 2024
@thomashohn
Copy link
Contributor Author

@kobenguyent - so Tests are green, removed the requirement to devtools and updated to latest webdriverio on v8 - there might be some documentation that needs adoptions?

@kobenguyent
Copy link
Collaborator

@kobenguyent - so Tests are green, removed the requirement to devtools and updated to latest webdriverio on v8 - there might be some documentation that needs adoptions?

Oh great! Thanks for your hard work! regarding docs, just edit the jsdocs, then run npm run docs, it would update the .md files for you.

@thomashohn
Copy link
Contributor Author

Yes - I was more unsure what to update exactly ;-) And the command seems to update a lot more than I changed ,,,

@kobenguyent
Copy link
Collaborator

@kobenguyent
Copy link
Collaborator

Screenshot 2024-11-12 at 22 55 02
just noticed some places.

docs/changelog.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency of devtools
2 participants