Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AI): send promise to endpoint when calling askGptOnPage actions #4486

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

tomaculum
Copy link
Contributor

Motivation/Description of the PR

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
Copy link
Collaborator

Nice! Thanks for catching it!

@kobenguyent kobenguyent changed the title Fixed issue #4471 fix(AI): send promise to endpoint when calling askGptOnPage actions Sep 4, 2024
@kobenguyent kobenguyent merged commit cd76743 into codeceptjs:3.x Sep 4, 2024
11 of 13 checks passed
@tomaculum tomaculum deleted the patch-1 branch September 4, 2024 14:05
@kobenguyent kobenguyent mentioned this pull request Sep 17, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I.askGptOnPage and I.askGptOnPageFragment sends Promise to endpoint
2 participants