Skip to content

hotfix: missing joi package #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2024
Merged

hotfix: missing joi package #4209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c73c9bc
hotfix: missing joi package
kobenguyent Feb 19, 2024
e8a1027
fix: specify browser version
kobenguyent Feb 19, 2024
ecea789
fix: specify browser version
kobenguyent Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 3.5.14

❤️ Thanks all to those who contributed to make this release! ❤️

🐛 *Bug Fixes*
* **Hotfix** Fixed missing `joi` package - by @KobeNguyenT

## 3.5.13

❤️ Thanks all to those who contributed to make this release! ❤️
Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "codeceptjs",
"version": "3.5.13",
"version": "3.5.14",
"description": "Supercharged End 2 End Testing Framework for NodeJS",
"keywords": [
"acceptance",
Expand Down Expand Up @@ -97,6 +97,7 @@
"glob": "6.0.1",
"html-minifier-terser": "7.2.0",
"inquirer": "6.5.2",
"joi": "17.12.1",
"js-beautify": "1.14.11",
"lodash.clonedeep": "4.5.0",
"lodash.merge": "4.6.2",
Expand Down Expand Up @@ -171,4 +172,4 @@
"npm": ">=5.6.0"
},
"es6": true
}
}
4 changes: 3 additions & 1 deletion test/helper/WebDriver.noSeleniumServer_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ global.codeceptjs = require('../../lib');

const siteUrl = TestHelper.siteUrl();
let wd;

const browserVersion = '116.0.5793.0';
describe('WebDriver - No Selenium server started', function () {
this.retries(1);
this.timeout(35000);
Expand All @@ -34,6 +34,7 @@ describe('WebDriver - No Selenium server started', function () {
windowSize: '500x700',
smartWait: 0, // just to try
waitForTimeout: 5000,
browserVersion,
capabilities: {
chromeOptions: {
args: ['--headless', '--disable-gpu', '--window-size=1280,1024'],
Expand Down Expand Up @@ -1220,6 +1221,7 @@ describe('WebDriver - Basic Authentication', () => {
basicAuth: { username: 'admin', password: 'admin' },
browser: 'chrome',
windowSize: '500x700',
browserVersion,
remoteFileUpload: true,
smartWait: 0, // just to try
waitForTimeout: 5000,
Expand Down