Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright apply bypassCSP to contextOptions #3865

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

sammeel
Copy link
Contributor

@sammeel sammeel commented Sep 13, 2023

Motivation/Description of the PR

With #3641 the documentation was updated that you can set the bypassCSP property of playwright. Upon further investigation we noticed that the property is not set when creating a playwright context.

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@sammeel sammeel marked this pull request as ready for review September 13, 2023 09:41
@kobenguyent kobenguyent merged commit 36eccd6 into codeceptjs:3.x Sep 15, 2023
9 checks passed
@sammeel sammeel deleted the playwrightDisableCsp branch September 15, 2023 05:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants