Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated: nightmare #3754

Merged
merged 6 commits into from
Jul 13, 2023
Merged

deprecated: nightmare #3754

merged 6 commits into from
Jul 13, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • Deprecated Nightmare helper as it's not actively maintained anymore.

@DavertMik
Copy link
Contributor

@kobenguyent something wrong with definitions

Could you regenerate them with

./runok.js def

And try again?

@kobenguyent
Copy link
Collaborator Author

@kobenguyent something wrong with definitions

Could you regenerate them with


./runok.js def

And try again?

I ran npm run def which is fine on my local.

@kobenguyent kobenguyent changed the title depreacted: nightmare deprecated: nightmare Jul 12, 2023
@DavertMik
Copy link
Contributor

Sorry, now it conflicts with merged Protractor )))
Maybe you have one PR?

@kobenguyent kobenguyent merged commit b3d5a4b into 3.x Jul 13, 2023
@kobenguyent kobenguyent deleted the deprecate-nightmare branch July 13, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

@DavertMik DavertMik DavertMik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobenguyent @DavertMik @Arhell