Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playwright): checking network stuff #3748

Merged
merged 11 commits into from
Jul 20, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

Applicable helpers:

  • Playwright

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@ngraf
Copy link
Contributor

ngraf commented Jul 10, 2023

I am happy to see my unpolished custom helper being picked up and potentially becoming part of official CodeceptJS library.
The code as it is in the Gist is already battle proven. I used this helper a lot over many months of productive execution.

There is one feature missing that I would consider important before it is mature enough for community:
Support to check POST parameters with I.seeTraffic. Currently only GET parameters are supported. I am sure it is doable to check POST parameters as well. I was just lagging the need and time to implement this as well.

@DavertMik
Copy link
Contributor

@ngraf could you improve this PR by adding usage examples into docblocks? Please, please!

@kobenguyent is it possible for you to implement

Support to check POST parameters with I.seeTraffic

if not, this limitation should be mentioned in documentation

@kobenguyent
Copy link
Collaborator Author

@ngraf could you improve this PR by adding usage examples into docblocks? Please, please!

@kobenguyent is it possible for you to implement

Support to check POST parameters with I.seeTraffic

if not, this limitation should be mentioned in documentation

updated the docs along with POST verifications

@ngraf
Copy link
Contributor

ngraf commented Jul 11, 2023

@ngraf could you improve this PR by adding usage examples into docblocks? Please, please!

Ok, I will try to contribute usage examples in doclblocks this week @DavertMik .

lib/helper/Playwright.js Outdated Show resolved Hide resolved
lib/helper/Playwright.js Outdated Show resolved Hide resolved
@ngraf
Copy link
Contributor

ngraf commented Jul 12, 2023

@ngraf could you improve this PR by adding usage examples into docblocks? Please, please!

As promised I created a pull-request that contains some examples for the docblocks:
#3758

lib/helper/Playwright.js Outdated Show resolved Hide resolved
lib/helper/Playwright.js Outdated Show resolved Hide resolved
kobenguyent and others added 4 commits July 13, 2023 14:39
…elper (#3758)

* added examples in docblocks of new network test steps in Playwright helper

* added examples in docblocks of new network test steps in Playwright helper

---------

Co-authored-by: Norbert Graf <[email protected]>
Co-authored-by: KobeNguyenT <[email protected]>
@kobenguyent kobenguyent merged commit a6b3f54 into 3.x Jul 20, 2023
8 checks passed
@kobenguyent kobenguyent deleted the feat-playwright-more-custom-steps branch July 20, 2023 10:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants