Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight fixes #3722

Merged
merged 4 commits into from
Jul 2, 2023
Merged

Highlight fixes #3722

merged 4 commits into from
Jul 2, 2023

Conversation

DavertMik
Copy link
Contributor

  • auto start highlight in debug mode
  • replaced border with box shadow as it doesn't change the layout
  • refactored code to simplify

kobenguyent
kobenguyent reviewed Jul 2, 2023
View reviewed changes
lib/helper/scripts/highlightElement.js
} catch (e) {
context.execute(el => el.style.border = '2px solid red', element);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavertMik not sure if the eval works for webdriver that's why I used execute here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, got it

@DavertMik DavertMik merged commit 5b28e0b into 3.x Jul 2, 2023
7 of 8 checks passed
@DavertMik DavertMik deleted the highlight-fixes branch July 2, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobenguyent kobenguyent kobenguyent approved these changes

@EgorBodnar EgorBodnar Awaiting requested review from EgorBodnar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavertMik @kobenguyent