Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try out docker image push by tags #3704

Merged
merged 13 commits into from
Jul 7, 2023
Merged

fix: try out docker image push by tags #3704

merged 13 commits into from
Jul 7, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • Description of this PR, which problem it solves
  • Resolves #issueId (if applicable).

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent marked this pull request as draft June 20, 2023 15:38
@kobenguyent kobenguyent marked this pull request as ready for review June 21, 2023 15:30
@DavertMik
Copy link
Contributor

@kobenguyent why do we push previous tag and not current one?

@kobenguyent
Copy link
Collaborator Author

Hey @DavertMik sorry for the confusing name. It's actually getting the current tag.

@DavertMik
Copy link
Contributor

@kobenguyent but we also need to push the latest tag as well for the latest release....
could you update the code so it also kept latest auto-updated?

@kobenguyent
Copy link
Collaborator Author

Done @DavertMik

@DavertMik
Copy link
Contributor

Thanks!

@DavertMik DavertMik merged commit c86bfc8 into 3.x Jul 7, 2023
9 checks passed
@DavertMik DavertMik deleted the kobenguyent-patch-1 branch July 7, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants