Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong context is passed to close the trace of session #3698

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • Fix the error that cannot close context due to the wrong context is passed

Current Issue

When running tests with multiple sessions, when test fails, the wrong context is passed that leads to this error.

    [3] <teardown> Error | Error: tracing.stop: Target page, context or browser has been closed
Error: tracing.stop: Target page, context or browser has been closed

Applicable helpers:

  • Playwright

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent merged commit 71cbd92 into 3.x Jun 25, 2023
@kobenguyent kobenguyent deleted the fix-wrong-context-passed-to-close-trace branch August 28, 2023 15:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants