Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(run-workers) : Add support of multiple browsers for run-workers #3606

Merged
merged 6 commits into from
May 28, 2023
Merged

feat(run-workers) : Add support of multiple browsers for run-workers #3606

merged 6 commits into from
May 28, 2023

Conversation

karanshah-browserstack
Copy link
Contributor

@karanshah-browserstack karanshah-browserstack commented Mar 1, 2023 •
edited
Loading

Motivation/Description of the PR

  • Adding Support of using multiple with run-workers to run multiple browsers out of the box with workers instead of triggering it by manually creating a custom runner.

Type of change

  • 🚀 New functionality

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@karanshah-browserstack karanshah-browserstack mentioned this pull request Mar 1, 2023
Closed
Arhell
Arhell reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavertMik

@karanshah-browserstack
Copy link
Contributor Author

@Arhell @DavertMik Do we have any update on this?

2 similar comments
@karanshah-browserstack
Copy link
Contributor Author

@Arhell @DavertMik Do we have any update on this?

@karanshah-browserstack
Copy link
Contributor Author

@Arhell @DavertMik Do we have any update on this?

DavertMik
DavertMik approved these changes May 28, 2023
View reviewed changes
Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems like a useful feature. Sorry for the delay reviewing it. I am going to merge it soon and make a release

DavertMik
DavertMik approved these changes May 28, 2023
View reviewed changes
Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the best of two worlds, run-multiple and run-workers

Thank you so much for this awesome feature!

@DavertMik DavertMik merged commit dfec1d9 into codeceptjs:3.x May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@DavertMik DavertMik DavertMik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karanshah-browserstack @DavertMik @Arhell