Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization #238

Closed
wants to merge 3 commits into from
Closed

Optimization #238

wants to merge 3 commits into from

Conversation

fluflo
Copy link

@fluflo fluflo commented Apr 23, 2020

Summary

To give the developers more possibilities to influence the rendering of the icon on the QR code, I made the following extensions:

  1. allow to specify if the border of the icon should have rounded corners
  2. to give the QR code a cleaner look, I have added the option not to render the modules if they are hidden under the icon. This will result in an extended border, and it is no longer possible to have rounded corners.

This PR fixes/implements the following bugs/features:

  • [ X] Decide, if the border of the icons has rounded corners or angular
  • [ X] Decide, if the QR-Code should render modules, that are partly hidden behind the icon.

What existing problem does the pull request solve?

When rendering an icon on the qr-code, it doesn't provide a lot of possibilities to change the look of it. If someone dislikes the partly rendered modules, there was no possibility to change that.

Test plan
As there are no bigger changes and the code still uses the same methods no tests are added.
Under the following link, are two examples of the new feature. link to images

Closing issues

Fixes #230 #231

fluflo added 3 commits April 23, 2020 10:05
Update GetGraphic method to add the possibility to draw angular corners and to not render qr code modules, if they are partly hidden by the icon.
To use the drawRoundedCorners and renderPartlyHiddenModule parameters.
@codebude
Copy link
Owner

Same functionality already implemented via #245

@codebude codebude closed this Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon without rounded corners
2 participants