Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To give the developers more possibilities to influence the rendering of the icon on the QR code, I made the following extensions:
This PR fixes/implements the following bugs/features:
What existing problem does the pull request solve?
When rendering an icon on the qr-code, it doesn't provide a lot of possibilities to change the look of it. If someone dislikes the partly rendered modules, there was no possibility to change that.
Test plan
As there are no bigger changes and the code still uses the same methods no tests are added.
Under the following link, are two examples of the new feature. link to images
Closing issues
Fixes #230 #231