Skip to content

Commit

Permalink
removed code that causes qr codes to generate incorrectly on linux an…
Browse files Browse the repository at this point in the history 
…d mac
  • Loading branch information
@sdraugelbb
sdraugelbb committed Jun 3, 2020
1 parent 60217f8 commit e886baa
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion QRCoder/QRCode.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ public Bitmap GetGraphic(int pixelsPerModule, Color darkColor, Color lightColor,
if (drawIconFlag)
{
var region = new Region(r);
region.Exclude(iconPath);
gfx.FillRegion(darkBrush, region);
}
else
Expand Down

1 comment on commit e886baa

@DamienLaw
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this commit:
image

After this commit:
image

I'd like it better before this commit though. BTW, this is taken from a Windows machine.
This commit has rendered the iconBorderWidth not being used anymore. So it's pointless specifying it in QRCode.GetGraphic().

It would be best if the background colour of the icon can be set to non-transparent. Even better if the background colour can be set to colours other than lightColor.

Please sign in to comment.