Feature implementation from commits 17207fc..5f3ae64

[codeOwlAI]

PR Summary

Socket Options and JSON Serialization Enhancements

Overview

This PR enhances socket options configuration with interface binding support and improves JSON serialization for DNS-related structs. It includes breaking changes to protobuf field numbering.

Change Types

Type	Description
Feature	Added socket binding to specific network interfaces
Enhancement	Improved JSON serialization for DNS-related structs
Refactor	Replaced custom network functions with standard net.ListenConfig
Breaking	Renumbered protobuf fields in CustomSockopt message

---

Affected Modules

Module / File	Change Description
conf/dns.go	Added JSON marshaling support for HostsWrapper struct
conf/fakedns.go	Added MarshalJSON method to FakeDNSConfig for handling mutually exclusive fields
internet/config.pb.go	Added new 'system' field and renumbered protobuf fields (breaking change)
internet/sockopt_darwin.go	Added interface binding and custom socket options for Darwin
internet/sockopt_windows.go	Added IPv6 and custom socket options for Windows
internet/system_dialer.go	Refactored to use standard net.ListenConfig

---

Breaking Changes

• Renumbered all existing fields in the CustomSockopt protobuf definition, which breaks wire compatibility with existing clients
• Removed getInterfaceIndexByName function from sockopt_darwin.go
• Removed IP_MULTICAST_IF and IPV6_MULTICAST_IF constants from sockopt_windows.go

---

Notes for Reviewers

• Verify that the new socket binding functionality works correctly across platforms
• Ensure JSON serialization/deserialization is symmetric for DNS-related structs
• Check for potential compatibility issues with existing clients due to protobuf field renumbering

[codeowlai]

🐛 Correctness Issue

Breaking Protobuf Field Numbering Change.

The change renumbers all existing fields in the CustomSockopt message, which breaks wire compatibility with any existing serialized data or clients.

Proposed Code:

12, 0x16, 0x0a, 0x06, 0x73, 0x79, 0x73, 0x74, 0x65, 0x6d, 0x18, 0x01, 0x20, 0x01, 0x28, 0x09, 0x52, 0x06, 0x73, 0x79, 0x73, 0x74, 0x65, 0x6d

[codeowlai]

🐛 Correctness Issue

Ignoring error return from strconv.Atoi().

The code ignores the error return from strconv.Atoi(), which could lead to using an invalid socket option value if the conversion fails.

Current Code (Diff):

- 				opt, _ = strconv.Atoi(custom.Opt)
+ 				var parseErr error
+ 				opt, parseErr = strconv.Atoi(custom.Opt)
+ 				if parseErr != nil {
+ 					return errors.New("failed to parse socket option").Base(parseErr)
+ 				}

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	opt, _ = strconv.Atoi(custom.Opt)
	var parseErr error
	opt, parseErr = strconv.Atoi(custom.Opt)
	if parseErr != nil {
	return errors.New("failed to parse socket option").Base(parseErr)
	}

[codeowlai]

🐛 Correctness Issue

Ignoring error return from strconv.Atoi().

The code ignores the error return from strconv.Atoi() for the socket level, which could lead to using an invalid socket level if the conversion fails.

Current Code (Diff):

- 				level, _ = strconv.Atoi(custom.Level)
+ 				var parseErr error
+ 				level, parseErr = strconv.Atoi(custom.Level)
+ 				if parseErr != nil {
+ 					return errors.New("failed to parse socket level").Base(parseErr)
+ 				}

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	level, _ = strconv.Atoi(custom.Level)
	var parseErr error
	level, parseErr = strconv.Atoi(custom.Level)
	if parseErr != nil {
	return errors.New("failed to parse socket level").Base(parseErr)
	}

[codeowlai]

🐛 Correctness Issue

Ignoring error return from strconv.Atoi().

The code ignores the error return from strconv.Atoi() for the socket option value, which could lead to using an invalid value if the conversion fails.

Current Code (Diff):

- 				value, _ := strconv.Atoi(custom.Value)
+ 				value, err := strconv.Atoi(custom.Value)
+ 				if err != nil {
+ 					return errors.New("failed to parse socket option value").Base(err)
+ 				}

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	value, _ := strconv.Atoi(custom.Value)
	value, err := strconv.Atoi(custom.Value)
	if err != nil {
	return errors.New("failed to parse socket option value").Base(err)
	}

[codeowlai]

🔒 Security Issue

Hardcoded socket level constant.

Using a hardcoded hex value (0x6) for the socket level instead of a proper symbolic constant creates a maintenance risk and potential security issue.

Current Code (Diff):

- 			var level = 0x6 // default TCP
+ 			var level = unix.IPPROTO_TCP // default TCP

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	var level = 0x6 // default TCP
	var level = unix.IPPROTO_TCP // default TCP

[codeowlai]

🐛 Correctness Issue

Ignoring error from strconv.Atoi() for socket option.

The code discards the error from strconv.Atoi(), which could cause unpredictable behavior if the conversion fails and silently uses 0 as the option value.

Current Code (Diff):

-				opt, _ = strconv.Atoi(custom.Opt)
+				var err error
+				opt, err = strconv.Atoi(custom.Opt)
+				if err != nil {
+					return errors.New("failed to parse socket option").Base(err)
+				}

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	opt, _ = strconv.Atoi(custom.Opt)
	var err error
	opt, err = strconv.Atoi(custom.Opt)
	if err != nil {
	return errors.New("failed to parse socket option").Base(err)
	}

[codeowlai]

🐛 Correctness Issue

Ignoring error from strconv.Atoi() for level value.

The code discards the error from strconv.Atoi() for the level value, which could lead to using incorrect socket option levels if conversion fails.

Current Code (Diff):

-				level, _ = strconv.Atoi(custom.Level)
+				var err error
+				level, err = strconv.Atoi(custom.Level)
+				if err != nil {
+					return errors.New("failed to parse socket level").Base(err)
+				}

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	level, _ = strconv.Atoi(custom.Level)
	var err error
	level, err = strconv.Atoi(custom.Level)
	if err != nil {
	return errors.New("failed to parse socket level").Base(err)
	}

[codeowlai]

🐛 Correctness Issue

Ignoring error from strconv.Atoi() for option value.

The code discards the error from strconv.Atoi() when parsing the option value, potentially causing undefined socket behavior with invalid inputs.

Current Code (Diff):

-				value, _ := strconv.Atoi(custom.Value)
+				value, err := strconv.Atoi(custom.Value)
+				if err != nil {
+					return errors.New("failed to parse socket option value").Base(err)
+				}

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	value, _ := strconv.Atoi(custom.Value)
	value, err := strconv.Atoi(custom.Value)
	if err != nil {
	return errors.New("failed to parse socket option value").Base(err)
	}

[codeowlai]

🐛 Correctness Issue

Uninformative error message.

The error message "No opt!" is not descriptive enough for debugging and doesn't match the style of other error messages in the codebase.

Current Code (Diff):

-				return errors.New("No opt!")
+				return errors.New("missing required socket option value")

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	return errors.New("No opt!")
	return errors.New("missing required socket option value")

[codeowlai]

🐛 Correctness Issue

Ignored Conversion Error in Socket Option.

The code ignores potential Atoi conversion errors when parsing custom socket options, which could cause invalid socket configurations if non-numeric values are provided.

Current Code (Diff):

- 				opt, _ = strconv.Atoi(custom.Opt)
+ 				opt, err := strconv.Atoi(custom.Opt)
+ 				if err != nil {
+ 					return errors.New("Invalid socket option value").Base(err)
+ 				}

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	opt, _ = strconv.Atoi(custom.Opt)
	opt, err := strconv.Atoi(custom.Opt)
	if err != nil {
	return errors.New("Invalid socket option value").Base(err)
	}

[codeowlai]

🐛 Correctness Issue

Ignored Conversion Error in Socket Level.

The code ignores potential Atoi conversion errors when parsing the socket level, which could apply incorrect socket configurations if non-numeric values are provided.

Current Code (Diff):

- 				level, _ = strconv.Atoi(custom.Level)
+ 				level, err := strconv.Atoi(custom.Level)
+ 				if err != nil {
+ 					return errors.New("Invalid socket level value").Base(err)
+ 				}

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	level, _ = strconv.Atoi(custom.Level)
	level, err := strconv.Atoi(custom.Level)
	if err != nil {
	return errors.New("Invalid socket level value").Base(err)
	}

[codeowlai]

🐛 Correctness Issue

Ignored Conversion Error in Socket Value.

The code ignores potential Atoi conversion errors when parsing the custom socket value, which could lead to incorrect socket options being applied.

Current Code (Diff):

- 				value, _ := strconv.Atoi(custom.Value)
+ 				value, err := strconv.Atoi(custom.Value)
+ 				if err != nil {
+ 					return errors.New("Invalid socket option value").Base(err)
+ 				}

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	value, _ := strconv.Atoi(custom.Value)
	value, err := strconv.Atoi(custom.Value)
	if err != nil {
	return errors.New("Invalid socket option value").Base(err)
	}

[codeowlai]

🐛 Correctness Issue

Hardcoded Protocol Assumption.

The code hardcodes level 0x6 (IPPROTO_TCP) without verifying the socket type, which could cause incorrect socket configurations for non-TCP protocols.

Current Code (Diff):

- 			var level = 0x6 // default TCP
+ 			var level int
+ 			if strings.HasPrefix(network, "tcp") {
+ 				level = 0x6 // IPPROTO_TCP
+ 			} else if strings.HasPrefix(network, "udp") {
+ 				level = 0x11 // IPPROTO_UDP
+ 			} else {
+ 				level = 0x0 // SOL_SOCKET for general socket options
+ 			}

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

	var level = 0x6 // default TCP
	var level int
	if strings.HasPrefix(network, "tcp") {
	level = 0x6 // IPPROTO_TCP
	} else if strings.HasPrefix(network, "udp") {
	level = 0x11 // IPPROTO_UDP
	} else {
	level = 0x0 // SOL_SOCKET for general socket options
	}