-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wook] Step19 리뷰 부탁드립니다. #34
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a1b35a2
chore: 배경 css 변경
pocokim b41231b
refactor: state를 todos로 변경
pocokim f2ff25d
refactor: calcStatusCnt 함수 삭제
pocokim c8683c2
chore: 함수명 변경
pocokim 3ab3bf8
refactor: router에 따른 폴더구조 변경
pocokim 8b60830
feat: Home , Header 컴포넌트구현및 스타일링
pocokim 6456f78
style: Home 컴포넌트 문장 배치수정
pocokim ba4cd7b
chore: 배포, 개발용 변경기능 구현
pocokim a11bdff
feat: PropTypes로 TodoItem 구현
pocokim 74db1b2
feat: StateContext.Provider에 proptypes 구현
pocokim bc842b4
refactor: 최적화를 위한 Provider별 value분리
pocokim c890547
chore: TodoItem propTypes id change
pocokim 9baad4a
refactor: TodoItem을 react.memo로 최적화함
pocokim 9d81800
chore: 주석 삭제
pocokim 22c267a
docs: 최적화관련 진행사항 기록
pocokim bbc9672
refactor: react-router 초기화면 home 컴포넌트로 변경
pocokim d40f88a
bugfix: 탭간 이동시 status 남아있도록 구현
pocokim d653db8
refactor: client 하위로 폴더구조 변경
pocokim e9dd4c2
feat: dev 용 서버코드 작성
pocokim 2e81604
refactor: change port number
pocokim 4f3152d
refactor: express.Router 이용해 분리
pocokim 1cbd786
refactor: json파일 따로 분리후 읽어오도록 변경
pocokim 36d66d6
chore: 불필요한 주석 제거
pocokim ad2da91
bugfix: webpack 개발, 배포용 변경
pocokim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
{ | ||
"statusCode": 200, | ||
"body": [ | ||
{ | ||
"title": "로컬서버 웹팩에서 데이터 받아오기", | ||
"id": 1233, | ||
"status": "todo" | ||
}, | ||
{ | ||
"title": "서버코드 작성하기", | ||
"id": 1234, | ||
"status": "todo" | ||
}, | ||
{ | ||
"title": "라우터 404, 스위치 처리하기", | ||
"id": 1230, | ||
"status": "todo" | ||
}, | ||
{ | ||
"title": "step20 테스트코드", | ||
"id": 1231, | ||
"status": "todo" | ||
}, | ||
{ | ||
"title": "step21 인증", | ||
"id": 1231, | ||
"status": "todo" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
분리 잘 했음
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mongo db 연동도 해보면 좋겠죠.
NoSQL이 연동하기 쉽더라고요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
step 21 인증 하면서 기회가 되면 db도 구현해보겠습니다!