-
Couldn't load subscription status.
- Fork 16
feat(nx-plugin): add general executor logic #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 6c7277a with source commit 2f8d78e. 🏷️ Categories🗃️ Groups👍 2 groups improved
18 other groups are unchanged. 🛡️ Audits👍 5 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score
489 other audits are unchanged. |
1 task
4 tasks
matejchalk
requested changes
Jul 12, 2024
packages/nx-plugin/src/executors/internal/config.integration.test.ts
Outdated
Show resolved
Hide resolved
...ages/nx-plugin/src/generators/configuration/__snapshots__/generator.integration.test.ts.snap
Show resolved
Hide resolved
matejchalk
reviewed
Jul 12, 2024
...ages/nx-plugin/src/generators/configuration/__snapshots__/generator.integration.test.ts.snap
Outdated
Show resolved
Hide resolved
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
matejchalk
reviewed
Jul 12, 2024
Co-authored-by: Matěj Chalk <[email protected]>
matejchalk
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧩 core
🧩 nx-plugin
📖 Project documentation
improvements or additions to the project documentation
🔬 testing
writing tests
🛠️ tooling
🧩 utils
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the general executor logic to the
nx-pluginpackage.It includes:
autorunexecutor feat(nx-plugin): add executor to nx-plugin #737Potential improvements:
Related to:
#63