Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Jul 10, 2024

This PR add the general executor logic to the nx-plugin package.

It includes:

Potential improvements:

Related to:
#63

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 6c7277a with source commit 2f8d78e.

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🟡 55 ↑ +0.8
Code coverage 🟡 89 🟡 89 ↑ +0
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟢 100 🟢 100
Updates 🟡 78 🟡 78
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 2 groups improved
🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🟡 55 ↑ +0.8
Code coverage Code coverage metrics 🟡 89 🟡 89 ↑ +0

18 other groups are unchanged.

🛡️ Audits

👍 5 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 6.0 s 🟥 6.7 s ↑ +12 %
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟨 2.9 s ↓ −8 %
Lighthouse Time to Interactive 🟥 14.6 s 🟥 17.1 s ↑ +17 %
Lighthouse First Contentful Paint 🟨 2.9 s 🟨 2.9 s ↓ −3 %
Lighthouse First Meaningful Paint 🟨 2.9 s 🟨 2.9 s ↓ −3 %
Code coverage Branch coverage 🟨 83.7 % 🟨 83.5 % ↓ +0 %
Code coverage Line coverage 🟩 91.8 % 🟩 91.9 % ↑ +0 %
Code coverage Function coverage 🟩 91.8 % 🟩 91.9 % ↑ +0 %
Lighthouse Minimizes main-thread work 🟥 17.8 s 🟥 21.9 s ↑ +23 %
Lighthouse Metrics 🟩 14630 🟩 17061 ↑ +17 %
Lighthouse Total Blocking Time 🟥 5,310 ms 🟥 7,660 ms ↑ +44 %
Lighthouse JavaScript execution time 🟥 7.2 s 🟥 9.2 s ↑ +29 %
Lighthouse Max Potential First Input Delay 🟥 1,680 ms 🟥 2,930 ms ↑ +75 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,787 KiB 🟩 Total size was 1,787 KiB ↓ +0 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 650 ms 🟥 Potential savings of 810 ms ↑ +25 %
Lighthouse Initial server response time was short 🟩 Root document took 420 ms 🟩 Root document took 360 ms ↓ −14 %
Lighthouse Uses efficient cache policy on static assets 🟨 28 resources found 🟨 28 resources found ↓ +0 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 105 KiB 🟥 Potential savings of 105 KiB ↓ −4 %
Lighthouse Server Backend Latencies 🟩 210 ms 🟩 220 ms ↑ +7 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 50 ms ↓ −9 %

489 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review July 11, 2024 00:27
@BioPhoton BioPhoton requested a review from matejchalk July 11, 2024 00:28
@BioPhoton BioPhoton requested a review from matejchalk July 12, 2024 16:11
@BioPhoton BioPhoton requested a review from matejchalk July 12, 2024 17:38
@BioPhoton BioPhoton enabled auto-merge (rebase) July 12, 2024 18:06
@BioPhoton BioPhoton merged commit 2951228 into main Jul 12, 2024
@BioPhoton BioPhoton deleted the executor-utils branch July 12, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants