-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#217): CH.Slideshow autoPlay and autoPlayLoop #250
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
…deshow-auto # Conflicts: # packages/mdx/src/mdx-client/slideshow.tsx
If you merge the other PR and there are conflicts here, @ me if you want me to go through to resolve them. 👍🏽 |
Thank you.
|
…deshow-auto # Conflicts: # packages/mdx/src/mdx-client/slideshow.tsx
Done.
Yikes. I accidentally branched from the wrong spot on my end where I was trying to see if I could get presence animation working for motion components in slides. Luckily there were not many changes to back out.
Go for it. Conflicts resolved from the previous branch merge. |
🚀 PR was released in |
Resolves #217
autoPlay
andautoPlayLoop
to CH.Slideshow component.slideNext()
andslidePrevious()
to make code easier to follow and DRY when used in useEffectautoPlayLoop
is not configured, prevent side effect and timeout are not called againautoPlayLoop
is configured, an additional timeout is set to allow the last slide to show before resetting to the beginning slideautoPlay
is not configured.