Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting on /diversity #61913

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Oct 21, 2024

Using git-bisect, I tracked the regression to #60782. Looking at the Redcarpet release notes related to the upgrade in that PR, I found vmg/redcarpet#702, which seems like our culprit. As the center tag is deprecated, I simply removed it in this PR.

I did try to use a div or p tag here instead, with some CSS to recenter, but couldn't quite figure out how to make that work (it's worth mentioning that div and p tags are also "block level tags").

Also, I'm not sure why the code.org programs table is magically fixed (the first screenshot) but I flipped between staging and this branch locally and confirmed it was broken on the staging branch and fixed on this branch. 🤷‍♀️

Screenshot 2024-10-21 at 4 27 43 PM Screenshot 2024-10-21 at 11 28 17 AM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor marked this pull request as ready for review October 21, 2024 20:29
@bethanyaconnor bethanyaconnor requested a review from a team October 21, 2024 20:29
Copy link
Contributor

@hannahbergam hannahbergam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the before and after! LGTM!

@bethanyaconnor bethanyaconnor merged commit 0a75654 into staging Oct 22, 2024
4 checks passed
@bethanyaconnor bethanyaconnor deleted the bethany/fix-diversity-formatting branch October 22, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants