The seawater_admin cannot update the emergency_council.

[c4-bot-6]

Lines of code

https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/lib.rs#L1121

Vulnerability details

Impact

Due to a logic error in the update_emergency_council_7_D_0_C_1_C_58 function, the emergency_council in the contract cannot be updated by the seawater_admin.
This will result in the emergency_council contract being unable to be upgraded after it becomes outdated, and the nft_manager may be incorrectly set.

Proof of Concept

    /// Update the emergency council that can disable the pools.
    #[allow(non_snake_case)]
    pub fn update_emergency_council_7_D_0_C_1_C_58(
        &mut self,
        manager: Address,
    ) -> Result<(), Revert> {
        assert_eq_or!(
            msg::sender(),
            self.seawater_admin.get(),
            Error::SeawaterAdminOnly
        );

        self.nft_manager.set(manager);

        Ok(())
    }

The update_emergency_council_7_D_0_C_1_C_58 function mistakenly sets the nft_manager to the provided emergency_council address. This results in the nft_manager being incorrectly set, and the emergency_council not being updated.

Tools Used

Manual Review

Recommended Mitigation Steps

    /// Update the emergency council that can disable the pools.
    #[allow(non_snake_case)]
    pub fn update_emergency_council_7_D_0_C_1_C_58(
        &mut self,
-       manager: Address,
+       emergency: Address,
    ) -> Result<(), Revert> {
        assert_eq_or!(
            msg::sender(),
            self.seawater_admin.get(),
            Error::SeawaterAdminOnly
        );

-       self.nft_manager.set(manager);
+       self.emergency_council.set(emergency);

        Ok(())
    }

Assessed type

Error

[c4-judge]

alex-ppg changed the severity to 3 (High Risk)

[c4-judge]

alex-ppg marked the issue as satisfactory