Wrong operation

[howlbot-integration]

Lines of code

https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/sol/OwnershipNFTs.sol#L93

Vulnerability details

Impact

In function _onTransferReceived
...
require(
data != IERC721TokenReceiver.onERC721Received.selector,
"bad nft transfer received data"
);
}

It's wrong logic. Need to check if data is selector. Use == instead of !=

Recommended Mitigation Steps

require(
data == IERC721TokenReceiver.onERC721Received.selector,
"bad nft transfer received data"
);

Assessed type

Invalid Validation

[c4-judge]

alex-ppg changed the severity to 2 (Med Risk)

[c4-judge]

alex-ppg marked the issue as partial-50