Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis #77

Open
c4-bot-9 opened this issue Feb 27, 2024 · 5 comments
Open

Analysis #77

c4-bot-9 opened this issue Feb 27, 2024 · 5 comments
Labels

Comments

@c4-bot-9
Copy link
Contributor

See the markdown file with the details of this report here.

c4-bot-6 added a commit that referenced this issue Feb 27, 2024
c4-bot-8 added a commit that referenced this issue Feb 27, 2024
@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Mar 3, 2024
@c4-pre-sort
Copy link

0xRobocop marked the issue as sufficient quality report

@OpenCoreCH
Copy link

Unlike other reports, does not only provide generic descriptions / recommendations, but a concrete analysis with recommendations of the project

@c4-judge
Copy link

c4-judge commented Mar 8, 2024

OpenCoreCH marked the issue as grade-b

@iFrostizz
Copy link

This concern: https://github.com/code-423n4/2024-02-hydradx-findings/blob/main/data/Franfran-Analysis.md#adding-a-new-token-to-the-omnipool--create-a-stableswap-pool describes the same attack as #116 although arguably less detailed (no coded POC) because of the scope of the analysis. Could that still qualify for a partial credit ?

@OpenCoreCH
Copy link

The general idea behind the attack is indeed described, which is nice. However, I am not keen on giving partial credit for only providing an overall idea and a one sentence description of the impact without any details or assessing the feasibility. Such a submitted issue would be completely invalid (without partial credit), so I will treat it the same as part of the analysis.

@C4-Staff C4-Staff added the A-08 label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants