-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analysis #77
Comments
0xRobocop marked the issue as sufficient quality report |
Unlike other reports, does not only provide generic descriptions / recommendations, but a concrete analysis with recommendations of the project |
OpenCoreCH marked the issue as grade-b |
This concern: https://github.com/code-423n4/2024-02-hydradx-findings/blob/main/data/Franfran-Analysis.md#adding-a-new-token-to-the-omnipool--create-a-stableswap-pool describes the same attack as #116 although arguably less detailed (no coded POC) because of the scope of the analysis. Could that still qualify for a partial credit ? |
The general idea behind the attack is indeed described, which is nice. However, I am not keen on giving partial credit for only providing an overall idea and a one sentence description of the impact without any details or assessing the feasibility. Such a submitted issue would be completely invalid (without partial credit), so I will treat it the same as part of the analysis. |
See the markdown file with the details of this report here.
The text was updated successfully, but these errors were encountered: