-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
QA (Quality Assurance)Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntaxAssets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntaxbugSomething isn't workingSomething isn't workinginvalidThis doesn't seem rightThis doesn't seem rightunsatisfactorydoes not satisfy C4 submission criteria; not eligible for awardsdoes not satisfy C4 submission criteria; not eligible for awards
Description
[NON-CRITICAL] public functions not called by contract should be declared external
[NON-CRITICAL] Expressions for constant values such as call to keccak256(), should use immutable rather than constant
While it doesn’t save any gas because the compiler knows that developers often make this mistake, it’s still best to use the right tool for the task at hand. There is a difference between constant variables and immutable variables, and they should each be used in their appropriate contexts. constants should be used for literal values written into the code, and immutable variables should be used for expressions, or values calculated in, or passed into the constructor.
Change GraphTokenUpgradeable (this too) constants to immutable
Metadata
Metadata
Assignees
Labels
QA (Quality Assurance)Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntaxAssets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntaxbugSomething isn't workingSomething isn't workinginvalidThis doesn't seem rightThis doesn't seem rightunsatisfactorydoes not satisfy C4 submission criteria; not eligible for awardsdoes not satisfy C4 submission criteria; not eligible for awards