Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esbuild to pack bundler #810

Merged
merged 3 commits into from
Feb 22, 2021
Merged

Add esbuild to pack bundler #810

merged 3 commits into from
Feb 22, 2021

Conversation

alan-fang
Copy link
Contributor

Still need to test this.

Was there anything you were thinking of in terms of replacing make build in our sdk repo? I took a quick glance but am not too familiar with what we need as a base requirement for the generated files here. For example, looks like esbuild doesn't support declaration files. (evanw/esbuild#95)

@alan-fang alan-fang requested review from jonathan-codaio and a team February 19, 2021 23:43
Copy link
Collaborator

@jonathan-codaio jonathan-codaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Can we make this a CLI flag perhaps? Something like --compiler=esbuild or --compiler=webpack as the only two options, and the default is esbuild for now. No need to do the fallback, it'll just build with the specified compiler, and once we have enough infrastructure to run these we can see if it makes a difference which one is used.

No need to touch make build, the terminology is confusing, but that's just building TypeScript to JavaScript using tsc. In this case we're not really "building" but "bundling".

@alan-fang
Copy link
Contributor Author

Very cool. Can we make this a CLI flag perhaps? Something like --compiler=esbuild or --compiler=webpack as the only two options, and the default is esbuild for now. No need to do the fallback, it'll just build with the specified compiler, and once we have enough infrastructure to run these we can see if it makes a difference which one is used.

Yeah that's a better option. Updated!

Copy link
Collaborator

@jonathan-codaio jonathan-codaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alan-fang alan-fang merged commit 3bb330a into main Feb 22, 2021
@alan-fang alan-fang deleted the af-add-esbuild-bundler branch February 22, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants