-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Zend Framework integration to Laminas #343
base: main
Are you sure you want to change the base?
Conversation
Hi guys, can you do a review here? The pull request is for this ticket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to me (although I haven't used Laminas, I have to trust that the tests do their job ;) ) Just one small missed ZF2 → Laminas change and please remove the ZF2 section from the readme.
@loco8878 And thank you very much for the PR 🎉 |
Unfortunately, the implementation is not correct. Some things have been forgotten and some are too much. The packages for the module manager and the service manager, for example, are not required. |
I can do a review, but unfortunately not immediately. |
I suggest to extend the Composer configuration and add the module and config provider because this allows the usage of laminas-component-installer. Which is a Composer plugin for injecting modules and configuration providers into application configuration for laminas-mvc based applications and Mezzio applications. |
Here is another suggestion: #261 (comment) |
Input filter is added |
@froschdesign Could you take a quick look at the updated PR and check if it looks good now? Thank you so much in advance |
@froschdesign Can you please review this PR again? Many thanks. |
No description provided.