New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use self return type #45

Merged

florianeckerstorfer merged 1 commit into cocur:master from nreynis:feature/self-fluent-return-type

Nov 26, 2019

Contributor

nreynis commented Nov 25, 2019

I rewrote the return types to use self instead of Chain. This have several advantages:

remove a lot of clutter
API isn´t locked on Chain being the final class, in other words, you can now subclass Chain without breaking fluent design
mocked interfaces doesn´t need to account for a TypeError (removed the fragile test getFluentTypeErrorForMockedTrait)

Obsoletes #44

Kudos to Symfony for making me aware of this superior syntax.


          Use self return type

a878faa

florianeckerstorfer approved these changes

View reviewed changes

Member

florianeckerstorfer commented Nov 26, 2019

Thanks, awesome work

florianeckerstorfer merged commit 417739d into cocur:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet