-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for #19363 #19703
fix for #19363 #19703
Conversation
It seems there is a conflict, could you please fix it, and could you please modify other templates too. |
Done. I also updated the tests too. |
@MrCapone have you tested it? @PatriceJiang told me it didn't take effect to modify like this. The warnings are gone, but the task was not executed. |
I already using this code in my projects. Assets folder has been successfully generated and copied to apk. So nothing wrong with this line. |
I tested the current v3 branch with similar changes and the files were not copied to the assets folder. @MrCapone would you please tell which version of gradle is used in your project? |
@PatriceJiang im using gradle plugin v3.4.0 which downloading gradle 5.1.1 |
It is caused by gradle version change. |
I've tested CppTest from main branch without this commit and then on my branch with it. In both cases assets folder didn't created and REsources didn't copied. So this commit has nothing to do with that issue. Anyway my project from cpp-template still working fine. |
@PatriceJiang I've created empty project from my branch and tried build apk. Everything works fine. So gradle build scripts in cpp-template already working. |
Because we need to copy resources, and it doesn't depend any other thing. So i think we can copy resources not using gradle task. Then it will not be affected by gradle. |
not relevant |
Can you tell me how to resolve this problem ,it also happened to me |
#19363
https://discuss.cocos2d-x.org/t/cocos2d-x-3-17-and-android-studio-3-3-build-issue-or-error/45503/6?u=capone