Resolve potential OOM (Out-Of-Memory) issues in the Spine runtime for web platforms.#18610
Merged
dumganhar merged 9 commits intococos:v3.8.7from Apr 17, 2025
Merged
Resolve potential OOM (Out-Of-Memory) issues in the Spine runtime for web platforms.#18610dumganhar merged 9 commits intococos:v3.8.7from
dumganhar merged 9 commits intococos:v3.8.7from
Conversation
dumganhar
reviewed
Apr 14, 2025
native/cocos/editor-support/spine-wasm/spine-skeleton-instance.h
Outdated
Show resolved
Hide resolved
dumganhar
approved these changes
Apr 17, 2025
Contributor
|
@cocos-robot run test cases |
Code Size Check Report
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -53368,9 +53368,8 @@
protected _animationQueue: __private._cocos_spine_skeleton__AnimationItem[];
protected _headAniInfo: __private._cocos_spine_skeleton__AnimationItem | null;
protected _isAniComplete: boolean;
protected _playTimes: number;
- protected _needUpdateSkeltonData: boolean;
protected _listener: __private._cocos_spine_track_entry_listeners__TrackEntryListeners | null;
_vLength: number;
_vBuffer: Uint8Array | null;
_iLength: number;
|
|
@bofeng-song, Please check the result of
Task Details |
|
@bofeng-song, Please check the result of
Task Details |
Contributor
|
TrackEntry will be free after _queue->drain() fire EventType_End or EventType_Dispose. this pr cache TrackEntry and delay to do callback, this may cause an error on spineListenerCallBackFromJS to read SpineWasmUtil::s_currentEntry |
Contributor
Author
Thanks for your feedback, I'll check it |
Contributor
6 tasks
AILHC
pushed a commit
to AILHC/cocos-engine
that referenced
this pull request
May 19, 2025
…cos#18610) (cherry picked from commit a6c5ce0) # Conflicts: # native/cocos/editor-support/spine-wasm/spine-skeleton-instance.cpp # native/external-config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Re: #
cocos/cocos-test-projects#916
https://forum.cocos.org/t/topic/166062
cocos/cocos-engine-external#485
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: