Skip to content

Conversation

wxitcode
Copy link
Contributor

@wxitcode wxitcode commented May 10, 2025

fix #115

@cocool97
Copy link
Owner

Thanks for your PR, it looks good to me only need to test :)

What's the technical difference between shell and shell v2 ?

@wxitcode
Copy link
Contributor Author

The reply is late. I found that when using adb directly, it uses v2. It should have better performance and features. To be honest, I am not too familiar with the specific differences between them.

@cocool97
Copy link
Owner

In that case I think we can merge both commands and include everything under shell. If the device supports v2, this is the backend used by default.

This prevents adding another subcommand, and if Android already acts like that this is something we should consider.

@wxitcode
Copy link
Contributor Author

Totally agree.

@cocool97
Copy link
Owner

I tested a bit more and I have an issue with special characters I think, do you have it on your side ?

image

@wxitcode
Copy link
Contributor Author

I just tested and found that there is. It's 1 byte ID + 4 bytes length.

shell_protocol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support shell v2
2 participants