Add support for TD SMP #598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-jlange
reviewed
Jan 27, 2025
msft-jlange
reviewed
Jan 27, 2025
msft-jlange
reviewed
Jan 27, 2025
msft-jlange
reviewed
Jan 27, 2025
msft-jlange
reviewed
Jan 27, 2025
peterfang
force-pushed
the
tdx-smp
branch
2 times, most recently
from
013665b to
d2791bd
Compare
msft-jlange
reviewed
Jan 29, 2025
msft-jlange
reviewed
Jan 29, 2025
msft-jlange
reviewed
Jan 29, 2025
To improve the uniformity and maintainability of stage2's memory configuration, turn the following memory addresses into Rust consts: - End of low memory - Stage2 heap's starting address - Stage2 heap's ending address (same as end of low memory) Signed-off-by: Peter Fang <[email protected]>
msft-jlange
reviewed
Jan 30, 2025
msft-jlange
reviewed
Jan 30, 2025
msft-jlange
reviewed
Jan 30, 2025
msft-jlange
reviewed
Jan 30, 2025
Bringing up TD APs requires the use of a mailbox since TD vCPUs start in protected unpaged mode (i.e. INIT/SIPI is not supported). Put the mailbox at SIPI_STUB_GPA, where the SIPI startup stub would be inserted in case of a native platform. Reuse ApStartContext and the common path in smp.rs to bring up TD APs and put this context structure at exactly the same location (top of the SIPI stub page) as the one on native platforms. APs are signaled after the mailbox page is initialized and are brought up one by one. Co-developed-by: Zide Chen <[email protected]> Signed-off-by: Peter Fang <[email protected]>
Use the same bring-up logic as the implementation in native.rs. In place of an INIT/SIPI protocol, a software-based mailbox is used. Signed-off-by: Peter Fang <[email protected]>
msft-jlange
reviewed
Jan 30, 2025
msft-jlange
approved these changes
Jan 30, 2025
msft-jlange
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series reuses the logic introduced in #581. A software-based mailbox is used for AP signaling. TD APs will enter
ap_request_loop()after this series is applied.