Making zero_mem_region() and control regs helpers unsafe #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-jlange
reviewed
Dec 4, 2024
msft-jlange
suggested changes
Dec 4, 2024
Fixed now, thanks for the input Jon! |
joergroedel
added
needs-rebase
As advised by @Freax13 in coconut-svsm#359, if misused, zero_mem_region() can corrupt valid memory by writing zeroes to it. Therefore, it should be unsafe so that callers verfies that it points to the intended memory. Signed-off-by: Thomas Leroy <[email protected]>
Some functions only reading and/or writing to control registers can be linlined. Signed-off-by: Thomas Leroy <[email protected]>
stefano-garzarella
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zero_mem_region()should be unsafe.flush_tlb_global_percpu()unsafe too. Since I don't know perfectly the TLB code, maybe it's not necessary. Comments are very welcome here. Also, if it's correct to makeflush_tlb_global_percpu()unsafe, for consistency reason I guess we should put other TLB helpers unsafe (again, comments are welcome here).