panic: use a platform-specific halt routine #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-jlange
force-pushed
the
platform_hlt
branch
2 times, most recently
from
ec465c7 to
5fd436d
Compare
joergroedel
requested changes
Oct 24, 2024
Freax13
reviewed
Oct 25, 2024
msft-jlange
force-pushed
the
platform_hlt
branch
from
5fd436d to
e5c642c
Compare
Not all platforms support HLT as a way to halt execution, and therefore the panic halt must be performed through a platform-specific routine. However, at the time of a panic, the global platform object may not yet be initialized. Instead, use a more primitive mechanism for choosing a platform-specific halt routine during panic. Signed-off-by: Jon Lange <[email protected]>
msft-jlange
force-pushed
the
platform_hlt
branch
from
e5c642c to
4170523
Compare
Freax13
approved these changes
Oct 25, 2024
joergroedel
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all platforms support HLT as a way to halt execution, and therefore the panic halt must be performed through a platform-specific routine. However, at the time of a panic, the global platform object may not yet be initialized. Instead, use a more primitive mechanism for choosing a platform-specific halt routine during panic.