mm/pgtable: minor cleanups #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Construct different predefined sets of page table entry flags from the PTEntryFlags type instead of the PageTable type. Signed-off-by: Carlos López <[email protected]>
When allocating page table entries we simply need to know whether the allocation corresponds to a regular or huge page, so use the PageSize enum instead of a usize. Signed-off-by: Carlos López <[email protected]>
PTEntry::set() already fully sets the entry, so there's no need to clear it beforehand. Signed-off-by: Carlos López <[email protected]>
Attempting to unmap unmapped memory usually indicates something went wrong in the memory management subsystem, so log it as an error. Signed-off-by: Carlos López <[email protected]>
osteffenrh
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor code quality improvements for the pagetable code.