Skip to content

Comments

go.mod: update github.com/cockroachdb/swiss for Go 1.25 support#4952

Merged
RaduBerinde merged 1 commit intocockroachdb:masterfrom
stefanb:go-1.25
Jun 25, 2025
Merged

go.mod: update github.com/cockroachdb/swiss for Go 1.25 support#4952
RaduBerinde merged 1 commit intocockroachdb:masterfrom
stefanb:go-1.25

Conversation

@stefanb
Copy link
Contributor

@stefanb stefanb commented Jun 24, 2025

The Go 1.25 incompatibility found in

then:

The changes in this PR are tested in my fork:

If desired I can bring some or all commits from https://github.com/stefanb/pebble/pull/3 into this PR to have this tested in CI with latest Go 1.25 (currently at rc1).

Once this is merged I suggest to create a release so that downstream users have plenty of time to include this before Go 1.25 is released (scheduled for August).

@stefanb stefanb requested a review from a team as a code owner June 24, 2025 23:31
@stefanb stefanb requested a review from xxmplus June 24, 2025 23:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stefanb stefanb changed the title Bump github.com/cockroachdb/swiss for Go 1.25 support go.mod: update github.com/cockroachdb/swiss for Go 1.25 support Jun 24, 2025
@RaduBerinde
Copy link
Member

Hi,
We use master for CRDB-specific development. We should do this on the pebble-release-2.0 branch. I will create a new release afterwards.

@stefanb
Copy link
Contributor Author

stefanb commented Jun 25, 2025

Thanks, @RaduBerinde. As suggested, i have created a PR for the pebble-release-2.0 branch:

@RaduBerinde RaduBerinde merged commit b9786c4 into cockroachdb:master Jun 25, 2025
6 checks passed
@RaduBerinde
Copy link
Member

Thanks!

@stefanb stefanb deleted the go-1.25 branch July 15, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants