Skip to content

Commit

Permalink
db: persist Experimental.EnableColumnarBlocks in OPTIONS file
Browse files Browse the repository at this point in the history
  • Loading branch information
jbowens committed Oct 16, 2024
1 parent c719c4e commit b3993ff
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions metamorphic/options_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ func TestOptionsRoundtrip(t *testing.T) {
"MaxConcurrentCompactions:",
"MaxConcurrentDownloads:",
"Experimental.DisableIngestAsFlushable:",
"Experimental.EnableColumnarBlocks:",
"Experimental.EnableValueBlocks:",
"Experimental.IneffectualSingleDeleteCallback:",
"Experimental.IngestSplit:",
Expand Down
8 changes: 8 additions & 0 deletions options.go
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,9 @@ func (o *Options) String() string {
if o.Experimental.DisableIngestAsFlushable != nil && o.Experimental.DisableIngestAsFlushable() {
fmt.Fprintf(&buf, " disable_ingest_as_flushable=%t\n", true)
}
if o.Experimental.EnableColumnarBlocks != nil && o.Experimental.EnableColumnarBlocks() {
fmt.Fprintf(&buf, " enable_columnar_blocks=%t\n", true)
}
fmt.Fprintf(&buf, " flush_delay_delete_range=%s\n", o.FlushDelayDeleteRange)
fmt.Fprintf(&buf, " flush_delay_range_key=%s\n", o.FlushDelayRangeKey)
fmt.Fprintf(&buf, " flush_split_bytes=%d\n", o.FlushSplitBytes)
Expand Down Expand Up @@ -1685,6 +1688,11 @@ func (o *Options) Parse(s string, hooks *ParseHooks) error {
o.private.disableLazyCombinedIteration, err = strconv.ParseBool(value)
case "disable_wal":
o.DisableWAL, err = strconv.ParseBool(value)
case "enable_columnar_blocks":
var v bool
if v, err = strconv.ParseBool(value); err == nil {
o.Experimental.EnableColumnarBlocks = func() bool { return v }
}
case "flush_delay_delete_range":
o.FlushDelayDeleteRange, err = time.ParseDuration(value)
case "flush_delay_range_key":
Expand Down

0 comments on commit b3993ff

Please sign in to comment.