Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: advance to v23.2.0 #182

Conversation

cockroach-teamcity
Copy link
Member

@cockroach-teamcity cockroach-teamcity commented Feb 5, 2024

  • bump version to v23.2.0
  • update libgeos to 3.11.2

@celiala
Copy link
Contributor

celiala commented Feb 5, 2024

✅ update: bumping libgeos to 3.11.2 fixed the tests

when i run the below brew test commands locally they both pass:
- brew test ./Formula/cockroach.rb
- brew test ./Formula/cockroach-sql.rb

however, the CI failure is a 404 for /usr/lib/libgeos.3.11.2.dylib (see message below):

==> /usr/local/Cellar/cockroach/23.2.0/bin/cockroach sql --url=$XCOCKROACH_URL -
ERROR: st_isvalid(): geos: error during GEOS init: geos: cannot load GEOS from dir "/usr/local/lib/cockroach": geos error: dlopen(/usr/local/lib/cockroach/libgeos_c.dylib, 0x0001): Library not loaded: '@rpath/libgeos.3.11.2.dylib'
  Referenced from: '/usr/local/Cellar/cockroach/23.2.0/lib/cockroach/libgeos_c.dylib'
  Reason: tried: '/home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/12108/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-opt/bin/c-deps/libgeos_foreign.build_tmpdir/lib/libgeos.3.11.2.dylib' (no such file), '/home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/12108/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-opt/bin/c-deps/libgeos_foreign.build_tmpdir/lib/libgeos.3.11.2.dylib' (no such file), '/usr/local/lib/libgeos.3.11.2.dylib' (no such file), '/usr/lib/libgeos.3.11.2.dylib' (no such file)

@celiala
Copy link
Contributor

celiala commented Feb 5, 2024

Maybe related to this?

So the TLDR; here for Windows is that we are going to stop bundling pre compiled GEOS libraries. If users want to use GEOS they can either

a) download and build it themselves for Windows,
b) or use our Linux container image

Do I have that right? If so I am okay with this change.

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to fix the template - these are generated files. Probably the logic should be tweaked as well.

@rail
Copy link
Member

rail commented Feb 6, 2024

#186 to address this.

@rail rail closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants