errbase: prevent a call cycle for Formatter/SafeFormatter errors #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've found a need somewhere to implement an `Error()` method on a leaf by delegating the behavior to the `Formatter` or `SafeFormatter` interfaces. In that case, the `errors.IsAny` call inside the special handler causes a call cycle. This commit breaks the cycle by handling the special cases after the interfaces. A possible regression would be that one of the stdlib errors starts implementing `fmt.Formatter`, whereby we'd lose the special handling (which, as of this writing, extracts safe strings). At the time of this writing, none of the stdlib errors of interest implement `fmt.Formatter`, so we're punting dealing with that when/if it arises in the future.
tbg
approved these changes
Jan 18, 2022
|
Thanks! It would take me a long time to really scrutinize the changes to the control flow and I have not attempted to do that. However, I see how you're solving the problem and how the test cases demonstrate that. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88.
We've found a need somewhere to implement an
Error()method on aleaf by delegating the behavior to the
FormatterorSafeFormatterinterfaces. In that case, the
errors.IsAnycall inside thespecial handler causes a call cycle.
This commit breaks the cycle by handling the special cases after
the interfaces.
A possible regression would be that one of the stdlib errors
starts implementing
fmt.Formatter, whereby we'd lose the specialhandling (which, as of this writing, extracts safe strings).
At the time of this writing, none of the stdlib errors of interest
implement
fmt.Formatter, so we're punting dealing with thatwhen/if it arises in the future.
This change is