Skip to content

Conversation

@florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Nov 4, 2025

Fixes DOC-15338

In essential-metrics.md, added check for advanced_excluded_metrics.

Rendered preview

@netlify
Copy link

netlify bot commented Nov 4, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 9497644
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/690a4243797e820007a75dfb

@netlify
Copy link

netlify bot commented Nov 4, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 9497644
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/690a424382c0d700089182cd

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Files changed:

@netlify
Copy link

netlify bot commented Nov 4, 2025

Netlify Preview

Name Link
🔨 Latest commit 9497644
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/690a4243d28b7000088a1373
😎 Deploy Preview https://deploy-preview-20972--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@kevin-v-ngo kevin-v-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Florence, what should I be reviewing here?

I still see several "NOT AVAILABLE" metrics that should be removed from the docs. Is this automatically synced and will be removed at some point?

@florence-crl
Copy link
Contributor Author

@kevin-v-ngo

Hi Florence, what should I be reviewing here?

Rows for 4 metrics are no longer included for Advanced
sys.cpu.host.combined.percent-normalized
sys.host.disk.iopsinprogress
sql.mem.root.current
storage.write-stalls

For example, with this PR, a row for sys.host.disk.iopsinprogress will no longer appear: https://www.cockroachlabs.com/docs/v25.4/essential-metrics-advanced#sys-host-disk-iopsinprogress.

However, a row for sys.host.disk.read.bytes will still appear with "NOT AVAILABLE" in the second column: https://www.cockroachlabs.com/docs/v25.4/essential-metrics-advanced#sys-host-disk-read-bytes

I still see several "NOT AVAILABLE" metrics that should be removed from the docs. Is this automatically synced and will be removed at some point?

On this page (https://www.cockroachlabs.com/docs/v25.4/essential-metrics-advanced), there are 56 metrics with "NOT AVAILABLE" in the second column because these metrics do not have a match on the Datadog site (https://docs.datadoghq.com/integrations/cockroach-cloud/#metrics). Please clarify whether these 56 rows should be displayed.
Thanks!

@florence-crl
Copy link
Contributor Author

discussed with @kevin-v-ngo , I will filter Essential Metrics for Advanced once #21152 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants