-
Notifications
You must be signed in to change notification settings - Fork 478
DOC-15338: Remove metrics from Essential Metrics Advanced page #20972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
kevin-v-ngo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Florence, what should I be reviewing here?
I still see several "NOT AVAILABLE" metrics that should be removed from the docs. Is this automatically synced and will be removed at some point?
Rows for 4 metrics are no longer included for Advanced For example, with this PR, a row for However, a row for
On this page (https://www.cockroachlabs.com/docs/v25.4/essential-metrics-advanced), there are 56 metrics with "NOT AVAILABLE" in the second column because these metrics do not have a match on the Datadog site (https://docs.datadoghq.com/integrations/cockroach-cloud/#metrics). Please clarify whether these 56 rows should be displayed. |
|
discussed with @kevin-v-ngo , I will filter Essential Metrics for Advanced once #21152 is merged. |
Fixes DOC-15338
In essential-metrics.md, added check for advanced_excluded_metrics.
Rendered preview